Re: [PATCH V2] vmscan/trace: Add 'active' and 'file' info to trace_mm_vmscan_lru_isolate.
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-12-14 00:45:13
Also in:
lkml
On Sun, 11 Dec 2011 22:46:24 +0800 Tao Ma [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- a/mm/vmscan.c +++ b/mm/vmscan.c@@ -1103,7 +1103,7 @@ int __isolate_lru_page(struct page *page, isolate_mode_t mode, int file) static unsigned long isolate_lru_pages(unsigned long nr_to_scan, struct list_head *src, struct list_head *dst, unsigned long *scanned, int order, isolate_mode_t mode, - int file) + int active, int file) { unsigned long nr_taken = 0; unsigned long nr_lumpy_taken = 0;@@ -1221,7 +1221,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, nr_to_scan, scan, nr_taken, nr_lumpy_taken, nr_lumpy_dirty, nr_lumpy_failed, - mode); + mode, active, file); return nr_taken; }@@ -1237,7 +1237,7 @@ static unsigned long isolate_pages_global(unsigned long nr, if (file) lru += LRU_FILE; return isolate_lru_pages(nr, &z->lru[lru].list, dst, scanned, order, - mode, file); + mode, active, file); }
It would be nice to avoid adding permanent runtime overhead on behalf of tracing. It sounds like sending "mode" will satisfy this - please check that in the v2 patch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>