Thread (5 messages) 5 messages, 4 authors, 2011-09-02

Re: [PATCH] Enable OOM when moving processes between cgroups?

From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-09-01 00:09:53

On Wed, 31 Aug 2011 19:54:22 +0200
Johannes Weiner [off-list ref] wrote:
On Wed, Aug 31, 2011 at 08:32:21PM +0300, Viktor Rosendahl wrote:
quoted
Hello,

I wonder if there is a specific reason why the  OOM killer hasn't been enabled
in the mem_cgroup_do_precharge() function in mm/memcontrol.c ?

In my testing (2.6.32 kernel with some backported cgroups patches), it improves
the case when there isn't room for the task in the target cgroup.
Tasks are moved directly on behalf of a request from userspace.  We
would much prefer denying that single request than invoking the
oom-killer on the whole group.
Yes, I agree.
Quite a lot changed in the trycharge-reclaim-retry path since 2009.
Nowadays, charging is retried as long as reclaim is making any
progress at all, so I don't see that it would give up moving a task
too lightly, even without the extra OOM looping.

Is there any chance you could retry with a more recent kernel?
It's curious topic.

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help