On Fri, 2011-09-30 at 14:29 -0700, H. Peter Anvin wrote:

On 09/30/2011 01:32 PM, Dave Hansen wrote:

quoted

diff -puN lib/string_helpers.c~string_get_size-pow2 lib/string_helpers.c
 
+const char *units_10[] = { "B", "kB", "MB", "GB", "TB", "PB",
+			   "EB", "ZB", "YB", NULL};
+const char *units_2[] = {"B", "KiB", "MiB", "GiB", "TiB", "PiB",
+			 "EiB", "ZiB", "YiB", NULL };

These names are way too generic to be public symbols.

Ack, I managed to drop the static when I broke this out for the third
time. :)

Another thing worth thinking about is whether or not the -B suffix
should be part of these arrays.

... or the 'i' for that matter.

I'll give it a go.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>