Re: [PATCH v5 3.1.0-rc4-tip 1/26] uprobes: Auxillary routines to insert, find, delete uprobes
From: Srikar Dronamraju <hidden>
Date: 2011-09-26 16:34:30
Also in:
lkml
From: Srikar Dronamraju <hidden>
Date: 2011-09-26 16:34:30
Also in:
lkml
* Peter Zijlstra [off-list ref] [2011-09-26 15:35:15]:
On Tue, 2011-09-20 at 17:29 +0530, Srikar Dronamraju wrote:quoted
+static struct uprobe *__find_uprobe(struct inode * inode, loff_t offset)Here and elsewhere, your whitespace is off, it should read: struct inode *inode I think checkpatch will inform you of this, but I didn't check.
I have run checkpatch.pl --strict on all the patches and it doesnt report them. However I do see these whitespace in three places definitions for write_opcode, __find_uprobe, and find_uprobe. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>