Thread (34 messages) 34 messages, 8 authors, 2011-09-19

Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo

From: Vasiliy Kulikov <hidden>
Date: 2011-09-14 19:15:01
Also in: lkml

On Wed, Sep 14, 2011 at 11:41 -0700, Dave Hansen wrote:
On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
quoted
@@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
 
 static int __init slab_proc_init(void)
 {
-       proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
+       proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
+                   &proc_slabinfo_operations);
 #ifdef CONFIG_DEBUG_SLAB_LEAK
        proc_create("slab_allocators", 0, NULL, &proc_sla 
If you respin this, please don't muck with the whitespace.
OK, I was just removing checkpatch warnings.
 Otherwise,
I'm fine with this.  Distros are already starting to do this anyway in
userspace.

Reviewed-by: Dave Hansen <redacted>
Thank you!

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help