Thread (8 messages) 8 messages, 4 authors, 2011-09-16

Re: [PATCH] staging: zcache: fix cleancache crash

From: Francis Moreau <hidden>
Date: 2011-09-14 09:26:44
Also in: lkml

On Tue, Sep 13, 2011 at 10:56 PM, Dan Magenheimer
[off-list ref] wrote:
quoted
From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
Sent: Tuesday, September 13, 2011 1:19 PM
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org; linux-mm@kvack.org; ngupta@vflare.org; linux-kernel@vger.kernel.org;
francis.moro@gmail.com; Dan Magenheimer; Seth Jennings
Subject: [PATCH] staging: zcache: fix cleancache crash

After commit, c5f5c4db, cleancache crashes on the first
successful get. This was caused by a remaining virt_to_page()
call in zcache_pampd_get_data_and_free() that only gets
run in the cleancache path.

The patch converts the virt_to_page() to struct page
casting like was done for other instances in c5f5c4db.

Based on 3.1-rc4

Signed-off-by: Seth Jennings <redacted>
Yep, this appears to fix it!  Hopefully Francis can confirm.
Ok I can give this a try and let you know.

In the meantime, as I said to you privately, 3.1-rc3 doesn't have the
issue whereas 3.1-rc5 has.

Thanks
-- 
Francis

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help