Re: [PATCH 1 of 3] mremap: check for overflow using deltas
From: Johannes Weiner <hidden>
Date: 2011-08-08 08:20:38
From: Johannes Weiner <hidden>
Date: 2011-08-08 08:20:38
On Sat, Aug 06, 2011 at 06:58:03PM +0200, aarcange@redhat.com wrote:
From: Andrea Arcangeli <redacted> Using "- 1" relies on the old_end to be page aligned and PAGE_SIZE > 1, those are reasonable requirements but the check remains obscure and it looks more like an off by one error than an overflow check. This I feel will improve readibility. Signed-off-by: Andrea Arcangeli <redacted>
Acked-by: Johannes Weiner <redacted> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>