Re: [PATCH] mm: fix page-faults detection in swap-token logic
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-08-29 23:07:06
Also in:
lkml
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-08-29 23:07:06
Also in:
lkml
On Sat, 27 Aug 2011 12:32:01 +0300 Konstantin Khlebnikov [off-list ref] wrote:
After commit v2.6.36-5896-gd065bd8 "mm: retry page fault when blocking on disk transfer" we usually wait in page-faults without mmap_sem held, so all swap-token logic was broken, because it based on using rwsem_is_locked(&mm->mmap_sem) as sign of in progress page-faults.
If I'm interpreting this correctly, the thrash-handling logic has been effectively disabled for a year and nobody noticed.
This patch adds to mm_struct atomic counter of in progress page-faults for mm with swap-token.
We desperately need to delete some code from mm/. This seems like a great candidate. Someone prove me wrong? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>