Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c
From: Cong Wang <hidden>
Date: 2011-08-29 02:30:27
Also in:
linux-next, lkml
From: Cong Wang <hidden>
Date: 2011-08-29 02:30:27
Also in:
linux-next, lkml
ao? 2011a1'08ae??26ae?JPY 04:57, David Rientjes a??e??:
On Thu, 25 Aug 2011, Cong Wang wrote:quoted
quoted
No, it doesn't work, CONFIG_HUGETLBFS can be enabled with CONFIG_NUMA=y and CONFIG_SYSFS=n and that uses data structures from drivers/base/node.c which doesn't get compiled with this patch.So, you mean with CONFIG_NUMA=y&& CONFIG_SYSFS=n&& CONFIG_HUGETLBFS=y we still get compile error? Which data structures are used by hugetlbfs?node_states[], which is revealed at link time if you tried to compile your patch. It's obvious that we don't want to add per-node hugetlbfs attributes to sysfs directories if sysfs is disabled, so you need to modify the hugetlbfs code as well.
Makes sense. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>