Thread (14 messages) 14 messages, 7 authors, 2011-08-23

Re: [PATCH 2/4] debug-pagealloc: add support for highmem pages

From: Akinobu Mita <akinobu.mita@gmail.com>
Date: 2011-08-23 15:26:46
Also in: lkml

2011/8/23 Andrew Morton [off-list ref]:
This seems more complicated than is needed.  Couldn't we just do

static void poison_page(struct page *page)
{
       void *addr;

       preempt_disable();
       addr = kmap_atomic(page);
       set_page_poison(page);
       memset(addr, PAGE_POISON, PAGE_SIZE);
       kunmap_atomic(addr);
       preempt_enable();
}

?
This code looks much better.  I'll update the patch.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help