Re: [patch 2/8] mm: memcg-aware global reclaim
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2011-08-11 21:10:09
Also in:
lkml
On Thu, Aug 11, 2011 at 01:39:45PM -0700, Ying Han wrote:
quoted hunk ↗ jump to hunk
Please consider including the following patch for the next post. It causes crash on some of the tests where sc->mem_cgroup is NULL (global kswapd).diff --git a/mm/vmscan.c b/mm/vmscan.c index b72a844..12ab25d 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c@@ -2768,7 +2768,8 @@ loop_again: * Do some background aging of the anon list, togive * pages a chance to be referenced before reclaiming. */ - if (inactive_anon_is_low(zone, &sc)) + if (scanning_global_lru(&sc) && + inactive_anon_is_low(zone, &sc)) shrink_active_list(SWAP_CLUSTER_MAX, zone, &sc, priority, 0);
Thanks! I completely overlooked this one and only noticed it after changing the arguments to shrink_active_list(). On memcg configurations, scanning_global_lru() will essentially never be true again, so I moved the anon pre-aging to a separate function that also does a hierarchy loop to preage the per-memcg anon lists. I hope to send out the next revision soon. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>