Thread (43 messages) 43 messages, 7 authors, 2011-08-03

Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages

From: Johannes Weiner <hidden>
Date: 2011-08-03 11:06:54
Also in: linux-xfs, lkml

On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote:
On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote:
quoted
Direct reclaim should never writeback pages. Warn if an attempt
is made.

Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Johannes Weiner <redacted>
Oops, too fast.

Shouldn't the WARN_ON() be at the top of the function, rather than
just warn when the write is deferred due to delalloc?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help