Thread (16 messages) 16 messages, 4 authors, 2011-07-06

Re: [PATCH] [Cleanup] memcg: export memory cgroup's swappiness v2

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-06-29 20:01:26
Also in: lkml

On Wed, 29 Jun 2011 19:03:25 +0900
KAMEZAWA Hiroyuki [off-list ref] wrote:
Each memory cgroup has 'swappiness' value and it can be accessed by
get_swappiness(memcg). The major user is try_to_free_mem_cgroup_pages()
and swappiness is passed by argument. It's propagated by scan_control.

get_swappiness is static function but some planned updates will need to
get swappiness from files other than memcontrol.c
This patch exports get_swappiness() as mem_cgroup_swappiness().
By this, we can remove the argument of swapiness from try_to_free...
and drop swappiness from scan_control. only memcg uses it.
+extern unsigned int mem_cgroup_swappiness(struct mem_cgroup *mem);
+unsigned int mem_cgroup_swappiness(struct mem_cgroup *memcg)
+static int vmscan_swappiness(struct scan_control *sc)
The patch seems a bit confused about the signedness of swappiness.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help