On 06/14, Srikar Dronamraju wrote:

* Oleg Nesterov [off-list ref] [2011-06-13 21:57:01]:

quoted

quoted

+	mutex_lock(&mapping->i_mmap_mutex);
+	vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, 0, 0) {

I didn't actually read this patch yet, but this looks suspicious.
Why begin == end == 0? Doesn't this mean we are ignoring the mappings
with vm_pgoff != 0 ?

Perhaps this should be offset >> PAGE_SIZE?

Okay,
I guess you meant something like this.

	vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, pgoff, pgoff) {

where pgoff == offset >> PAGE_SIZE
Right?

Yes, modulo s/PAGE_SIZE/PAGE_SHIFT. But please double check, I can be
easily wrong ;)

Oleg.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>