Re: [PATCH v2 1/3] coredump: use get_task_comm for %e filename format
From: WANG Cong <hidden>
Date: 2011-05-12 10:49:10
Also in:
linux-fsdevel
From: WANG Cong <hidden>
Date: 2011-05-12 10:49:10
Also in:
linux-fsdevel
On Thu, 12 May 2011 08:18:11 +0200, Jiri Slaby wrote:
We currently access current->comm directly. As we have prctl(PR_SET_NAME), we need the access be protected by task_lock. This is exactly what get_task_comm does, so use it. I'm not 100% convinced prctl(PR_SET_NAME) may be called at the time of core dump, but the locking won't hurt. Note that siglock is not held in format_corename.
John Stultz is working on some patches to convert get_task_common() to printk %ptc, you will not need to worry about the locking issue. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>