Thread (8 messages) 8 messages, 3 authors, 2011-05-04

Re: [PATCH 2/2] writeback: elevate queue_io() into wb_writeback()

From: Wu Fengguang <hidden>
Date: 2011-05-04 11:15:47
Also in: linux-fsdevel, lkml

On Wed, May 04, 2011 at 07:08:49PM +0800, Christoph Hellwig wrote:
quoted
 	return 1;
 }
 
-void writeback_inodes_wb(struct bdi_writeback *wb,
-		struct writeback_control *wbc)
+static void __writeback_inodes_wb(struct bdi_writeback *wb,
+				  struct writeback_control *wbc)
 {
 	int ret = 0;
 
 	if (!wbc->wb_start)
 		wbc->wb_start = jiffies; /* livelock avoidance */
This should move to writeback_inodes_wb and be unconditional as
wb_writeback already always initializes it.
Never mind :) wbc->wb_start has been killed in a later patch named
"writeback: avoid extra sync work at enqueue time".

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help