Re: [PATCH] mm: optimize replace_page_cache_page
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-03-21 22:07:30
Also in:
lkml
On Thu, 24 Feb 2011 11:56:55 +0100 Miklos Szeredi [off-list ref] wrote:
On Thu, 2011-02-24 at 08:37 +0900, Minchan Kim wrote:quoted
On Thu, Feb 24, 2011 at 7:44 AM, Andrew Morton [off-list ref] wrote:quoted
On Sun, 20 Feb 2011 08:41:21 +0900 Minchan Kim [off-list ref] wrote:quoted
Resend.Reignore.quoted
he patch is based on mmotm-2011-02-04 + mm-add-replace_page_cache_page-function-add-freepage-hook.patch. On Fri, Feb 11, 2011 at 01:33:46AM +0900, Minchan Kim wrote:quoted
This patch optmizes replace_page_cache_page. 1) remove radix_tree_preload 2) single radix_tree_lookup_slot and replace radix tree slot 3) page accounting optimization if both pages are in same zone. Cc: Miklos Szeredi <redacted> Cc: Rik van Riel <redacted> Cc: KAMEZAWA Hiroyuki <redacted> Cc: Mel Gorman <redacted> Signed-off-by: Minchan Kim <redacted> --- mm/filemap.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 51 insertions(+), 10 deletions(-) Hi Miklos, This patch is totally not tested. Could you test this patch?^^^ Because of this. Is it tested yet?Miklos. Could you test this? If you are busy, let me know how to test it. I will. Thanks.Grab git version of libfuse and do something like this: fuse/example/fusexmp_fh -obig_writes /mnt/fuse/ dd if=/tmp/random0 of=/mnt/fuse/tmp/random1 bs=1M md5sum /tmp/radom0 /tmp/random1 This should exercise the page moving. I'll review and test the patch when I have some time.
Too late. It took months to half-finish Miklos's patch and now I'm sitting on other patches which depend on it, so it's going in. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>