Thread (5 messages) read the whole thread 5 messages, 2 authors, 2011-02-17

Re: [2.6.32 ubuntu] I/O hang at start_this_handle

From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: 2011-02-15 21:53:03
Also in: linux-fsdevel

Jan Kara wrote:
  Ext3 looks innocent here. That is a standard call path for open(..,
O_TRUNC). But apparently something broke in SLUB allocator. Adding proper
list to CC...
Thanks.

Both fs/jbd/transaction.c and fs/jbd2/transaction.c provide start_this_handle()
and I don't know which one was called.

But

	if (!journal->j_running_transaction) {
		new_transaction = kzalloc(sizeof(*new_transaction),
					  GFP_NOFS|__GFP_NOFAIL);
		if (!new_transaction) {
			ret = -ENOMEM;
			goto out;
		}
	}

does kzalloc(GFP_NOFS|__GFP_NOFAIL) causes /proc/$PID/status to show

  State:  D (disk sleep)

line? I thought this is either

	if (transaction->t_state == T_LOCKED) {
		DEFINE_WAIT(wait);

		prepare_to_wait(&journal->j_wait_transaction_locked,
				&wait, TASK_UNINTERRUPTIBLE);
		spin_unlock(&journal->j_state_lock);
		schedule();
		finish_wait(&journal->j_wait_transaction_locked, &wait);
		goto repeat;
	}

or

	if (needed > journal->j_max_transaction_buffers) {
		/*
		 * If the current transaction is already too large, then start
		 * to commit it: we can then go back and attach this handle to
		 * a new transaction.
		 */
		DEFINE_WAIT(wait);

		jbd_debug(2, "Handle %p starting new commit...\n", handle);
		spin_unlock(&transaction->t_handle_lock);
		prepare_to_wait(&journal->j_wait_transaction_locked, &wait,
				TASK_UNINTERRUPTIBLE);
		__jbd2_log_start_commit(journal, transaction->t_tid);
		spin_unlock(&journal->j_state_lock);
		schedule();
		finish_wait(&journal->j_wait_transaction_locked, &wait);
		goto repeat;
	}

within start_this_handle().

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help