Re: [PATCH 8/8] Add VM counters for transparent hugepages
From: Andrea Arcangeli <hidden>
Date: 2011-02-24 04:19:39
Also in:
lkml
Incremental fix for your patch 8 (I doubt it was intentional). === Subject: thp: move THP_SPLIT from __split_huge_page_pmd to inner split_huge_page From: Andrea Arcangeli <redacted> Provide more accurate stats by accounting every split_huge_page not only the ones coming from pmd manipulations. Signed-off-by: Andrea Arcangeli <redacted> --- mm/huge_memory.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c@@ -1393,6 +1393,7 @@ int split_huge_page(struct page *page) BUG_ON(!PageSwapBacked(page)); __split_huge_page(page, anon_vma); + count_vm_event(THP_SPLIT); BUG_ON(PageCompound(page)); out_unlock:
@@ -2287,9 +2288,6 @@ void __split_huge_page_pmd(struct mm_str spin_unlock(&mm->page_table_lock); return; } - - count_vm_event(THP_SPLIT); - page = pmd_page(*pmd); VM_BUG_ON(!page_count(page)); get_page(page); --
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>