Re: [PATCH] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages
From: Naoya Horiguchi <hidden>
Date: 2011-02-22 00:32:06
Also in:
lkml
From: Naoya Horiguchi <hidden>
Date: 2011-02-22 00:32:06
Also in:
lkml
On Mon, Feb 21, 2011 at 04:47:49PM +0100, Petr Holasek wrote:
When user insert negative value into /proc/sys/vm/nr_hugepages it will result in the setting a random number of HugePages in system (can be easily showed at /proc/meminfo output). This patch fixes the wrong behavior so that the negative input will result in nr_hugepages value unchanged. Signed-off-by: Petr Holasek <redacted> --- mm/hugetlb.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bb0b7c1..f99d7a8 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c@@ -1872,8 +1872,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy, unsigned long tmp; int ret; - if (!write) - tmp = h->max_huge_pages; + tmp = h->max_huge_pages;
Looks reasonable. hugetlb_overcommit_handler() has the same wrong behavior. So how about fixing that too? Anyway, Reviewed-by: Naoya Horiguchi <redacted> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>