Thread (6 messages) 6 messages, 2 authors, 2011-02-21
STALE5625d REVIEWED: 2 (0M)

[PATCH v2 1/2] memcg: remove unnecessary BUG_ON

From: Minchan Kim <hidden>
Date: 2011-02-20 15:17:38
Also in: lkml
Subsystem: memory management, memory management - memory policy and migration, the rest · Maintainers: Andrew Morton, David Hildenbrand, Linus Torvalds

Now memcg in unmap_and_move checks BUG_ON of charge.
But mem_cgroup_prepare_migration returns either 0 or -ENOMEM.
If it returns -ENOMEM, it jumps out unlock without the check.
If it returns 0, it can pass BUG_ON. So it's meaningless.
Let's remove it.

Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Balbir Singh <redacted>
Acked-by: Daisuke Nishimura <redacted>
Acked-by: KAMEZAWA Hiroyuki <redacted>
Signed-off-by: Minchan Kim <redacted>
---
 mm/migrate.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index eb083a6..2abc9c9 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -683,7 +683,6 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
 		rc = -ENOMEM;
 		goto unlock;
 	}
-	BUG_ON(charge);
 
 	if (PageWriteback(page)) {
 		if (!force || !sync)
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help