Re: [PATCH 1/5] pagewalk: only split huge pages when necessary

On Thu, Feb 10, 2011 at 02:19:28PM +0100, Andrea Arcangeli wrote:

On Thu, Feb 10, 2011 at 11:11:25AM +0000, Mel Gorman wrote:

quoted

Before we goto this retry, there is at a cond_resched(). Just to confirm,
we are depending on mmap_sem to prevent khugepaged promoting this back to
a hugepage, right? I don't see a problem with that but I want to be
sure.

Correct, and we depend on that everywhere as wait_split_huge_page has
to run without holding spinlocks.

In that case;

Acked-by: Mel Gorman <redacted>

Thanks.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>