Re: [patch 2/3] memcg: prevent endless loop when charging huge pages to near-limit group
From: Minchan Kim <hidden>
Date: 2011-01-31 22:42:50
Also in:
lkml
From: Minchan Kim <hidden>
Date: 2011-01-31 22:42:50
Also in:
lkml
On Mon, Jan 31, 2011 at 11:03 PM, Johannes Weiner [off-list ref] wrote:
If reclaim after a failed charging was unsuccessful, the limits are checked again, just in case they settled by means of other tasks. This is all fine as long as every charge is of size PAGE_SIZE, because in that case, being below the limit means having at least PAGE_SIZE bytes available. But with transparent huge pages, we may end up in an endless loop where charging and reclaim fail, but we keep going because the limits are not yet exceeded, although not allowing for a huge page. Fix this up by explicitely checking for enough room, not just whether we are within limits. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Minchan Kim <redacted> -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>