Re: [PATCH 7/8] Use xvmalloc to store compressed chunks
From: Pekka Enberg <hidden>
Date: 2010-07-18 07:53:21
Also in:
lkml
Nitin Gupta wrote:
quoted hunk ↗ jump to hunk
@@ -528,17 +581,32 @@ static int zcache_store_page(struct zcache_inode_rb *znode, goto out; } - dest_data = kmap_atomic(zpage, KM_USER0); + local_irq_save(flags);
Does xv_malloc() required interrupts to be disabled? If so, why doesn't the function do it by itself?
+ ret = xv_malloc(zpool->xv_pool, clen + sizeof(*zheader),
+ &zpage, &zoffset, GFP_NOWAIT);
+ local_irq_restore(flags);
+ if (unlikely(ret)) {
+ ret = -ENOMEM;
+ preempt_enable();
+ goto out;
+ }-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>