Re: [patch v3] splice: fix race with page invalidation
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2008-07-30 17:03:53
Also in:
linux-fsdevel, lkml
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2008-07-30 17:03:53
Also in:
linux-fsdevel, lkml
On Wed, 30 Jul 2008, Miklos Szeredi wrote:
There are no real disadvantages: splice() from a file was originally meant to be asynchronous, but in reality it only did that for non-readahead pages, which happen rarely.
I still don't like this. I still don't see the point, and I still think there is something fundamentally wrong elsewhere. I also object to just dismissing the async nature as unimportant. Fix it instead. Make it use generic_file_readahead() or something. This is fixing things in all the wrong places, imnsho. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>