Re: Some interesting observations when trying to optimize vmstat handling

On Friday 09 November 2007 01:19, Jeremy Fitzhardinge wrote:

Andi Kleen wrote:

quoted

The only problem is that there might be some code who relies on
restore_flags() restoring other flags that IF, but at least for
interrupts and local_irq_save/restore it should be fine to change.

I don't think so.  We don't bother to save/restore the other flags in
Xen paravirt and it doesn't seem to cause a problem.  The semantics
really are specific to the state of the interrupt flag.

Yes i checked the code and only case I found is actually save_flags, not 
restore_flags

(and that particular case is even unnecessary) 

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>