Thread (18 messages) 18 messages, 4 authors, 2007-08-21

Re: [PATCH 6/6] Do not use FASTCALL for __alloc_pages_nodemask()

From: Mel Gorman <hidden>
Date: 2007-08-21 10:25:45
Also in: lkml

On (18/08/07 14:51), Andi Kleen didst pronounce:
On Friday 17 August 2007 23:07:33 Christoph Lameter wrote:
quoted
On Fri, 17 Aug 2007, Mel Gorman wrote:
quoted
Opinions as to why FASTCALL breaks on one machine are welcome.
Could we get rid of FASTCALL? AFAIK the compiler should automatically 
choose the right calling convention?
It was a nop for some time because register parameters are always enabled
on i386 and AFAIK no other architectures ever used it. Some out of tree
trees some to disable register parameters though, but that's not 
really a concern.
You're right. It now makes even less sense why it was a PPC64 machine that
exhibited the problem. It should have made no difference at all.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help