Thread (36 messages) 36 messages, 5 authors, 2006-10-06

Re: [PATCH] Get rid of zone_table V2

From: Andy Whitcroft <hidden>
Date: 2006-09-27 11:27:48

Andrew Morton wrote:
On Sun, 24 Sep 2006 03:06:43 -0700
Andrew Morton [off-list ref] wrote:
quoted
On Mon, 18 Sep 2006 12:21:35 -0700 (PDT)
Christoph Lameter [off-list ref] wrote:
quoted
 static inline int page_zone_id(struct page *page)
 {
-	return (page->flags >> ZONETABLE_PGSHIFT) & ZONETABLE_MASK;
-}
-static inline struct zone *page_zone(struct page *page)
-{
-	return zone_table[page_zone_id(page)];
+	return (page->flags >> ZONEID_PGSHIFT) & ZONEID_MASK;
 }
arm allmodconfig:

include/linux/mm.h: In function `page_zone_id':
include/linux/mm.h:450: warning: right shift count >= width of type
On a separate note.  I was able to get this puppy compiling enough to
see this warning and fix it, but nowhere close to compiling a kernel.

First, are you compiling here to a real kernel.  If so, is this on a
cross-compiler or a real system.  If its a cross-compiler which version.
  Do you have recipe for success?

I'd like to be incoporating more cross-compilation testing into our
nightlies, but this one isn't playing ball.

:/

-apw

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help