On Tue, 7 Feb 2006 12:29 pm, Con Kolivas wrote:

On Tue, 7 Feb 2006 11:38 am, Andrew Morton wrote:

quoted

Con Kolivas [off-list ref] wrote:

quoted

+	if (unlikely(!spin_trylock(&swapped.lock)))
+		goto out;

hm, spin_trylock() should internally do unlikely(), but it doesn't. 
(It's a bit of a mess, too).

Good point. Perhaps I should submit a separate patch for this instead.

A quick look at this code made me change my mind; there's heaps that could do 
with this treatment in spinlock.h. I'll let someone else tackle it.

Cheers,
Con

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>