Thread (26 messages) 26 messages, 4 authors, 2004-11-05

Re: fix iounmap and a pageattr memleak (x86 and x86-64)

From: Dave Hansen <hidden>
Date: 2004-11-03 02:49:12
Also in: lkml

Andrea Arcangeli wrote:
On Tue, Nov 02, 2004 at 05:43:45PM -0800, Dave Hansen wrote:
quoted
Oh, crap.  I meant to clear ->mapped when change_attr(__pgprot(0)) was 
done on it, and set it when it was changed back.  Doing that correctly 
preserves the symmetry, right?
yes it should. I agree with Andrew a bitflag would be enough. I'd call
it PG_prot_none.
It should be enough, but I don't think we want to waste a bitflag for 
something that's only needed for debugging anyway.  They're getting 
precious these days.  Might as well just bloat the kernel some more when 
the alloc debugging is on.

I'll see what I can do to get some backtraces of the __pg_prot(0) &&
page->mapped cases.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help