Thread (3 messages) 3 messages, 3 authors, 2003-08-13

Re: [patch] Add support for more than 256 zones

From: Andrew Morton <hidden>
Date: 2003-08-13 20:55:38

Jay Lan [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch is to support more than 256 zones for large systems.
The changes is to add #ifdef CONFIG_IA64 to mm.h to give different
#define to ZONE_SHIFT.

Thanks,
  - jay lan


diff -urN a-2.5.75/include/linux/mm.h b-2.5.75/include/linux/mm.h
--- a-2.5.75/include/linux/mm.h     Thu Jul 10 13:04:45 2003
+++ b-2.5.75/include/linux/mm.h     Tue Aug 12 17:20:22 2003
@@ -323,7 +323,11 @@
   * sets it, so none of the operations on it need to be atomic.
   */
  #define NODE_SHIFT 4
+#ifdef CONFIG_IA64
+#define ZONE_SHIFT (BITS_PER_LONG - 10)
+#else
  #define ZONE_SHIFT (BITS_PER_LONG - 8)
+#endif
Yes, this is good - it gives us five more page flags on 32-bit machines. 
Assuming that no 32 bit machiens will ever need more than three zones(?)

Please do it this way:

#ifndef ARCH_NR_ZONES_SHIFT
#define ARCH_NR_ZONES_SHIFT	3
#endif

#define ZONE_SHIFT (BITS_PER_LONG - ARCH_NR_ZONES_SHIFT)


and, in asm-ia64/page.h:

#define ARCH_NR_ZONES	10	/* 1024 zones */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help