Christoph Hellwig [off-list ref] wrote:

On Wed, Feb 26, 2003 at 02:20:24PM -0800, Andrew Morton wrote:

quoted

quoted

There's a bunch of minor fixes needed to disable the swap
code for systems with mmu.

A worthy objective.

quoted

+	.i_shared_sem	= __MUTEX_INITIALIZER(&swapper_space.i_shared_sem),

arch/um des not have __MUTEX_INITIALIZER, and I'm not sure that we want to
promote this to part of the kernel API, do we?

Might be better to leave that bit alone.  Maybe stick an initcall into
swap_state.c for it.

Personally I'd prefer to use __MUTEX_INITIALIZER because we really need
a way to intialize a semaphore at compile time.  Would either using
__SEMAPHORE_INITIALIZER() or renaming one of them to something more sane
be okay with you?

Actually I think I misread the UML code - seems that it just includes
the host architecture's semaphore.h, so what you have should be fine.
I'll queue it up.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>