Dave McCracken wrote:

--On Friday, December 27, 2002 16:03:11 -0800 Andrew Morton
[off-list ref] wrote:

quoted

Dave, could I ask you to check the locking changes carefully?  Some
of them are fairly nasty.  Thanks.

The only thing I specifically see is related to the pte_page_lock.  In
places where ptepage is derived from *pmd, the contents of *pmd can change
if another thread unshares that pte page on a fault.  There should be a
line like:

        ptepage = pmd_page(*pmd);

in the places where it reacquires the pte_page_lock.

I'll study it some more, but that stands out.

OK, thanks.  I just uploaded -mm2.  Probably the easiest way to review
my manglings is to just grep for page_add_rmap, and eyeball each site.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/