Re: page-flags.h
From: Daniel Phillips <hidden>
Date: 2002-08-29 19:04:59
On Tuesday 14 May 2002 22:25, Andrew Morton wrote:
inlines in headers are just a pita. I know it gets people all excited but I'd say: make 'em macros.
Responding to this old, old message - I strongly disagree. Macros just suck too much, because of type safety and self-documentation issues. Not only that, but using them extensively just lets the header inclusion order madness degenerate further. Anyway, header inclusion order is a solved problem as far as I'm concerned, please see my patches/posts with 'early page' subject line, on lkml. The winning strategy is to separate data declarations from function declarations, and automatically include the former in the latter. It's true that I haven't brought these patches forward to 2.5, and for that I can be faulted. There's still time though... -- Daniel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/