Thread (7 messages) 7 messages, 5 authors, 2002-05-15

Re: [RFC][PATCH] iowait statistics

From: Rik van Riel <hidden>
Date: 2002-05-14 12:30:32
Also in: lkml

On Mon, 13 May 2002, Andrew Morton wrote:
quoted
===== fs/buffer.c 1.64 vs edited =====
--- 1.64/fs/buffer.c    Mon May 13 19:04:59 2002
+++ edited/fs/buffer.c  Mon May 13 19:16:57 2002
@@ -156,8 +156,10 @@
        get_bh(bh);
        add_wait_queue(&bh->b_wait, &wait);
        do {
+               atomic_inc(&nr_iowait_tasks);
                run_task_queue(&tq_disk);
                set_task_state(tsk, TASK_UNINTERRUPTIBLE);
+               atomic_dec(&nr_iowait_tasks);
                if (!buffer_locked(bh))
                        break;
                schedule();
Shouldn't the atomic_inc cover the schedule()?
DOH, indeed.  Placed in the wrong place ;/

Rik
-- 
Bravely reimplemented by the knights who say "NIH".

http://www.surriel.com/		http://distro.conectiva.com/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help