Thread (3 messages) 3 messages, 3 authors, 2000-09-27

Re: [CFT][PATCH] ext2 directories in pagecache

From: Alexander Viro <hidden>
Date: 2000-09-27 09:22:35

On Wed, 27 Sep 2000, Ingo Molnar wrote:
On Wed, 27 Sep 2000, Marko Kreen wrote:
quoted
quoted
Why?
quoted
+                               } else if (de->name[2])
Sorry, I had a hard day and I should have gone to sleep already...
hey, you made Alexander notice an endianness bug so it was ok :-)
Definitely. Usually "it looks fishy" feeling should be trusted - if code
is non-obvious it's more likely to contain bugs.

How it was? "The goal is to write clear code, not clever code". And right
now dir.c in the patch is not clear enough - better than the corresponding
code in the tree (esp. in ext2_readdir()), but still needs cleaning up.

ObFsck: router in the $ORKPLACE apparently deciding that it's a good time
to shit itself and external SCSI on one of the home boxen joining the
fun. Sheesh...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help