Re: shrink_mmap bug in 2.2?

On Wed, Jun 14, 2000 at 06:16:10PM -0700, Kanoj Sarcar wrote:

Aren't you misreading the logic here? It is

	referenced && swap_count(page->offset) != 1)
	          ^^^^

[...]

So delete_from_swap_cache will only ever be called on a page
with swap_count(page->offset) == 1.

If the page is not referenced it will be removed regardless of
the swap_count.  My question is "does swap_count have to equal
one before calling delete_from_swap_cache"?  If it does then I
think the code is wrong.

I wouldn't consider this code old as it is in the current stable
kernel (2.2.16).  

  Neil

-- 
145 = 1! + 4! + 5!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/