--- v8
+++ v5
@@ -1,4 +1,4 @@
- Hi Miguel et al,
+ Hi all,
The Holtek HT16K33 LED controller is not only used for driving
dot-matrix displays, but also for driving segment displays.
@@ -19,44 +19,24 @@
Imagination Technologies ASCII LCD Display driver, for reuse,
- Patches 7-8 contain cleanups and improvements for the character line
display core driver,
- - Patches 9-17 contain a bug fixes, cleanups and improvements for the
+ - Patches 9-16 contain a bug fix, cleanups and improvements for the
HT16K33 driver, to prepare for segment display support,
- - Patch 18 adds support for 7/14-segment displays to the HT16K33
+ - Patch 17 adds support for 7/14-segment displays to the HT16K33
driver,
- - Patch 19 updates the HT16K33 DT bindings to document an LED subnode,
- - Patch 20 adds segment display LED support to the HT16K33 driver,
- to make use of hardware blinking, and to expose display color,
- - Patch 21 converts the HT16K33 driver to use device properties.
+ - Patch 18 updates the HT16K33 DT bindings to document an LED subnode,
+ - Patch 19 adds segment display LED support to the HT16K33 driver,
+ to make use of hardware blinking, and to expose display color.
-Changes compared to v7[1]:
- - Fix array upper bound check in map_to_seg14(),
- - Add Reviewed-by, Acked-by.
-
-Changes compared to v6[2]:
- - Add Acked-by, Reviewed-by,
- - New patch "auxdisplay: ht16k33: Fix frame buffer device blanking",
- - Add linux,default-trigger to example,
- - Add missing call to ht16k33_brightness_set() in
- ht16k33_fbdev_probe(), to make sure brightness and blinking are set
- to a sane state,
- - Integrate "auxdisplay: ht16k33: Make use of device properties" into
- this series.
-
-Changes compared to v5[3]:
- - Add Reviewed-by,
- - Reorder operations in ht16k33_led_probe() to ease future conversion
- to device properties.
-
-Changes compared to v4[4]:
+Changes compared to v4[1]:
- Add Reviewed-by,
- Add missing select NEW_LEDS.
-Changes compared to v3[5]:
+Changes compared to v3[2]:
- Combine compatible values for 7/14 segment displays into an enum,
- Add Reviewed-by,
- Add missing select LEDS_CLASS.
-Changes compared to v2[6]:
+Changes compared to v2[3]:
- Drop color property from display node,
- Use compat_only_sysfs_link_entry_to_kobj() instead of cooking our
own helper on top of kernfs_create_link(),
@@ -74,7 +54,7 @@
all LED properties from DT, instead of manual LED name construction
based on just the "color" property.
-Changes compared to v1[7]:
+Changes compared to v1[4]:
- Fix type of color to uint32,
- "refresh-rate-hz" is still required for dot-matrix displays.
- Move "select LINEDISP" for HT16K33 symbol to correct patch,
@@ -90,24 +70,18 @@
been tested on actual hardware. The changes to img-ascii-lcd.c are also
untested, due to lack of hardware.
-Thanks for applying!
+Thanks!
-[1] "[PATCH v7 00/21] auxdisplay: ht16k33: Add character display support"
- https://lore.kernel.org/r/20211012183327.649865-1-geert@linux-m68k.org/
-[2] "[PATCH v6 00/19] auxdisplay: ht16k33: Add character display support"
- https://lore.kernel.org/r/20210914143835.511051-1-geert@linux-m68k.org/
-[3] "[PATCH v5 00/19] auxdisplay: ht16k33: Add character display support"
- https://lore.kernel.org/r/20210811095759.1281480-1-geert@linux-m68k.org/
-[3] "[PATCH v4 00/19] auxdisplay: ht16k33: Add character display support"
+[1] "[PATCH v4 00/19] auxdisplay: ht16k33: Add character display support"
https://lore.kernel.org/r/20210727140459.3767788-1-geert@linux-m68k.org/
-[4] "[PATCH v3 00/19] auxdisplay: ht16k33: Add character display support"
+[2] "[PATCH v3 00/19] auxdisplay: ht16k33: Add character display support"
https://lore.kernel.org/r/20210714151130.2531831-1-geert@linux-m68k.org/
-[5] "[PATCH v2 00/18] auxdisplay: ht16k33: Add character display support"
+[3] "[PATCH v2 00/18] auxdisplay: ht16k33: Add character display support"
https://lore.kernel.org/r/20210625125902.1162428-1-geert@linux-m68k.org/
-[6] "[PATCH 00/17] auxdisplay: ht16k33: Add character display support"
+[4] "[PATCH 00/17] auxdisplay: ht16k33: Add character display support"
https://lore.kernel.org/r/20210322144848.1065067-1-geert@linux-m68k.org/
-Geert Uytterhoeven (21):
+Geert Uytterhoeven (19):
uapi: Add <linux/map_to_14segment.h>
dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays
auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string
@@ -117,7 +91,6 @@
auxdisplay: linedisp: Use kmemdup_nul() helper
auxdisplay: linedisp: Add support for changing scroll rate
auxdisplay: ht16k33: Connect backlight to fbdev
- auxdisplay: ht16k33: Fix frame buffer device blanking
auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize()
auxdisplay: ht16k33: Remove unneeded error check in keypad probe()
auxdisplay: ht16k33: Convert to simple i2c probe function
@@ -128,17 +101,16 @@
auxdisplay: ht16k33: Add support for segment displays
dt-bindings: auxdisplay: ht16k33: Document LED subnode
auxdisplay: ht16k33: Add LED support
- auxdisplay: ht16k33: Make use of device properties
- .../bindings/auxdisplay/holtek,ht16k33.yaml | 32 +-
- drivers/auxdisplay/Kconfig | 12 +-
+ .../bindings/auxdisplay/holtek,ht16k33.yaml | 31 +-
+ drivers/auxdisplay/Kconfig | 10 +
drivers/auxdisplay/Makefile | 1 +
- drivers/auxdisplay/ht16k33.c | 500 ++++++++++++++----
- drivers/auxdisplay/img-ascii-lcd.c | 205 ++-----
- drivers/auxdisplay/line-display.c | 261 +++++++++
+ drivers/auxdisplay/ht16k33.c | 473 ++++++++++++++----
+ drivers/auxdisplay/img-ascii-lcd.c | 205 ++------
+ drivers/auxdisplay/line-display.c | 261 ++++++++++
drivers/auxdisplay/line-display.h | 43 ++
- include/uapi/linux/map_to_14segment.h | 241 +++++++++
- 8 files changed, 1019 insertions(+), 276 deletions(-)
+ include/uapi/linux/map_to_14segment.h | 239 +++++++++
+ 8 files changed, 996 insertions(+), 267 deletions(-)
create mode 100644 drivers/auxdisplay/line-display.c
create mode 100644 drivers/auxdisplay/line-display.h
create mode 100644 include/uapi/linux/map_to_14segment.h