[PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static

From: Arnd Bergmann <arnd@arndb.de>

This function is only used locally and should be static to avoid a warning:

drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/irqchip/irq-mips-gic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index 6d5ecc10a8703..76253e864f230 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c

@@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
 	return gic_irq_domain_map(d, virq, hwirq);
 }
 
-void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
+static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
 			 unsigned int nr_irqs)
 {
 }

-- 
2.39.2

On 10/8/23 14:33, Arnd Bergmann wrote:

From: Arnd Bergmann <arnd@arndb.de>

This function is only used locally and should be static to avoid a warning:

drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
  drivers/irqchip/irq-mips-gic.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <redacted>

On Thu, Aug 10, 2023 at 02:33:55PM +0200, Arnd Bergmann wrote:

Right. Thanks! Note the descendant line should be aligned to the
function open parenthesis to preserve the coding style well
utilized in the driver. With that fixed feel free to add:

Reviewed-by: Serge Semin <redacted>

-Serge(y)

 {
 }
-- 
2.39.2