[PATCH] MIPS: jz4740: Add missing gpio.h include

Subsystems: mips, the rest

STALE4031d

4 messages, 3 authors, 2015-10-06 · open the first message on its own page

[PATCH] MIPS: jz4740: Add missing gpio.h include

From: Thierry Reding <hidden>
Date: 2015-10-05 11:29:35

Commit 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h") was
incomplete in that it didn't replace any of the includes for the JZ4740
platform and thus broke the qi_lb60_defconfig build.

Signed-off-by: Thierry Reding <redacted>
---
 arch/mips/jz4740/board-qi_lb60.c | 1 +
 arch/mips/jz4740/gpio.c          | 1 +
 2 files changed, 2 insertions(+)
diff --git a/arch/mips/jz4740/board-qi_lb60.c b/arch/mips/jz4740/board-qi_lb60.c
index 4e62bf85d0b0..f2885adda9d0 100644
--- a/arch/mips/jz4740/board-qi_lb60.c
+++ b/arch/mips/jz4740/board-qi_lb60.c
@@ -35,6 +35,7 @@
 
 #include <linux/leds_pwm.h>
 
+#include <asm/mach-jz4740/gpio.h>
 #include <asm/mach-jz4740/platform.h>
 
 #include "clock.h"
diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c
index 6cd69fdaa1c5..386626376b18 100644
--- a/arch/mips/jz4740/gpio.c
+++ b/arch/mips/jz4740/gpio.c
@@ -28,6 +28,7 @@
 #include <linux/seq_file.h>
 
 #include <asm/mach-jz4740/base.h>
+#include <asm/mach-jz4740/gpio.h>
 
 #define JZ4740_GPIO_BASE_A (32*0)
 #define JZ4740_GPIO_BASE_B (32*1)
-- 
2.5.0

Re: [PATCH] MIPS: jz4740: Add missing gpio.h include

From: Alban <albeu@free.fr>
Date: 2015-10-05 13:18:20

Am Mon,  5 Oct 2015 13:29:31 +0200
schrieb Thierry Reding [off-list ref]:
Commit 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h") was
incomplete in that it didn't replace any of the includes for the JZ4740
platform and thus broke the qi_lb60_defconfig build.
The fix for this break has just been merged upstream yesterday.

Alban

Re: [PATCH] MIPS: jz4740: Add missing gpio.h include

From: Thierry Reding <hidden>
Date: 2015-10-05 13:30:14

On Mon, Oct 05, 2015 at 03:18:03PM +0200, Alban wrote:
Am Mon,  5 Oct 2015 13:29:31 +0200
schrieb Thierry Reding [off-list ref]:
quoted
Commit 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h") was
incomplete in that it didn't replace any of the includes for the JZ4740
platform and thus broke the qi_lb60_defconfig build.
The fix for this break has just been merged upstream yesterday.
Okay, great.

Thanks,
Thierry

Re: [PATCH] MIPS: jz4740: Add missing gpio.h include

From: Ralf Baechle <hidden>
Date: 2015-10-06 11:30:02

On Mon, Oct 05, 2015 at 03:29:34PM +0200, Thierry Reding wrote:
quoted
quoted
platform and thus broke the qi_lb60_defconfig build.
The fix for this break has just been merged upstream yesterday.
Okay, great.
So I dropped this one.

  Ralf
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help