[PATCH]: you can't use p and p++ without a secuence point
DORMANTno replies
From: Juan Quintela <hidden>
Date: 2002-12-19 10:57:47
From: Juan Quintela <hidden>
Date: 2002-12-19 10:57:47
Hi
using p & p++ without a sequence point in the middle is
undefined behaviour. Once there fix the casts also.
and change == to = as normally == means identity, not
asignation :(
Later, Juan.
Index: arch/mips/lib/dump_tlb.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/lib/dump_tlb.c,v
retrieving revision 1.8.2.6
diff -u -r1.8.2.6 dump_tlb.c--- arch/mips/lib/dump_tlb.c 18 Dec 2002 22:47:37 -0000 1.8.2.6
+++ arch/mips/lib/dump_tlb.c 19 Dec 2002 10:38:02 -0000@@ -225,9 +226,7 @@ for(i=0;i<8;i++) { - printk("*%08lx == %08lx, ", - (unsigned long)p, (unsigned long)*p++); - printk("*%08lx == %08lx\n", - (unsigned long)p, (unsigned long)*p++); + printk("*%8p = %08lx, ", p, *p); p++; + printk("*%8p = %08lx\n", p, *p); p++; } }
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy