Re: CVS Update@oss.sgi.com: linux

On Wed, May 24, 2000 at 06:50:09PM +0200, Harald Koerfgen wrote:

Ok, trying to fix that I added a fastdep rule to arch/mips/tools/Makefile only to
find myself in a catch 22 situation. offset.c includes asm/ptrace.h which, in
turn, includes asm/offset.h, i.e. you have to have offset.h to create offset.h :-o

Without heavily messing around with several header files, which may have an
impact on non-MIPS platforms as well, I see no easy solution for that. Adding an
empty offset.h, on the other hand, and leaving the .cvsignore in place should at
least partially do what I want. Any objections?

And now for something completly different. Why the hell did I mess around with
that?

Well, if something in the kernel is changed which affects offset.h then
generating a diff against a fresh CVS copy will contain those differences. That
annoyed me because, personally, I find this disturbing when reviewing those diffs.
Nobody really needs that anyway, at least that's what I thought, because offset.h
is generated automatically.

The suggestion I made above would not solve that but at least avoids that those
changes creep into the CVS.

A good solution is important now that we have SMP.  Toggling CONFIG_SMP
affects offset.h and not for all variations of make invocations we
actually have the guarantee that offset.h is being rebuilt before using
it.

  Ralf

On 24-May-00 Ralf Baechle wrote:
[offset.h]

A good solution is important now that we have SMP.  Toggling CONFIG_SMP
affects offset.h and not for all variations of make invocations we
actually have the guarantee that offset.h is being rebuilt before using
it.

What about making offset.h to depend on $(TOPDIR)/.config?

This may cause unneccessary rebuilds of objects depending on offset.h after
configuration changes but it forces offset.h to be rebuilt when CONFIG_SMP is
toggled.

For example:

--- Makefile.old        Thu May 25 19:05:08 2000
+++ Makefile    Thu May 25 19:08:48 2000

@@ -18,7 +18,7 @@
 offset.h: offset.s
        sed -n '/^@@@/s///p' $^ >$@
 
-offset.s: offset.c
+offset.s: offset.c $(TOPDIR)/.config
 
 clean:
        rm -f offset.[hs] $(TARGET).new                                         

-- 
Regards,
Harald

On Thu, 25 May 2000, Harald Koerfgen wrote:

On 24-May-00 Ralf Baechle wrote:
[offset.h]

quoted

A good solution is important now that we have SMP.  Toggling CONFIG_SMP
affects offset.h and not for all variations of make invocations we
actually have the guarantee that offset.h is being rebuilt before using
it.

What about making offset.h to depend on $(TOPDIR)/.config?

This may cause unneccessary rebuilds of objects depending on offset.h after
configuration changes but it forces offset.h to be rebuilt when CONFIG_SMP is
toggled.

Would you mind removing the include/asm-$(ARCH)/offset.h from the CVS
repository, I get conflicts and stuff when I update.  I don't see why we need
to have a dummy file there.

Ulf