Thread (7 messages) 7 messages, 3 authors, 2021-12-22

Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers

From: Andy Shevchenko <hidden>
Date: 2021-12-21 20:21:40
Also in: linux-arm-kernel, linux-gpio, lkml

On Tue, Dec 21, 2021 at 9:13 PM Bartosz Golaszewski [off-list ref] wrote:
On Mon, Dec 20, 2021 at 4:11 PM Andy Shevchenko
[off-list ref] wrote:
quoted
On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski [off-list ref] wrote:
quoted
On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
[off-list ref] wrote:
...
quoted
quoted
quoted
-               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
+               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
This is unrelated though. Can you make it a separate patch?
It actually makes use of the local np IIRC.
It's related, no?
No, the np pointer is already used elsewhere. You just replace the
dev->of_node here with np. Rightfully so, but it's not part of this
commit logically.
I see. Probably I missed that somehow.
Nevertheless, do you want a new version or can you just revert that
particular change?

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help