Thread (37 messages) 37 messages, 3 authors, 2021-10-26

Re: [PATCH v6 13/16] drm/mediatek: add ETHDR support for MT8195

From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-10-21 15:46:41
Also in: dri-devel, linux-arm-kernel

Hi, Nancy:

Nancy.Lin [off-list ref] 於 2021年10月4日 週一 下午2:22寫道:
quoted hunk ↗ jump to hunk
ETHDR is a part of ovl_adaptor.
ETHDR is designed for HDR video and graphics conversion in the external
display path. It handles multiple HDR input types and performs tone
mapping, color space/color format conversion, and then combine
different layers, output the required HDR or SDR signal to the
subsequent display path.

Signed-off-by: Nancy.Lin <redacted>
---
 drivers/gpu/drm/mediatek/Makefile    |   1 +
 drivers/gpu/drm/mediatek/mtk_ethdr.c | 403 +++++++++++++++++++++++++++
 drivers/gpu/drm/mediatek/mtk_ethdr.h |  25 ++
 3 files changed, 429 insertions(+)
 create mode 100644 drivers/gpu/drm/mediatek/mtk_ethdr.c
 create mode 100644 drivers/gpu/drm/mediatek/mtk_ethdr.h
diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
index 6e604a933ed0..fb158a1e7f06 100644
--- a/drivers/gpu/drm/mediatek/Makefile
+++ b/drivers/gpu/drm/mediatek/Makefile
@@ -14,6 +14,7 @@ mediatek-drm-y := mtk_disp_aal.o \
                  mtk_drm_plane.o \
                  mtk_dsi.o \
                  mtk_dpi.o \
+                 mtk_ethdr.o \
                  mtk_mdp_rdma.o

 obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o
diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_ethdr.c
new file mode 100644
index 000000000000..99e5a95aebed
--- /dev/null
+++ b/drivers/gpu/drm/mediatek/mtk_ethdr.c
@@ -0,0 +1,403 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2021 MediaTek Inc.
+ */
+
+#include <drm/drm_fourcc.h>
+#include <linux/clk.h>
+#include <linux/reset.h>
+#include <linux/component.h>
+#include <linux/of_device.h>
+#include <linux/of_address.h>
+#include <linux/platform_device.h>
+#include <linux/soc/mediatek/mtk-cmdq.h>
+#include <linux/soc/mediatek/mtk-mmsys.h>
+
+#include "mtk_drm_crtc.h"
+#include "mtk_drm_ddp_comp.h"
+#include "mtk_drm_drv.h"
+#include "mtk_ethdr.h"
+
+#define MIX_INTEN              0x4
+       #define MIX_FME_CPL_INTEN       BIT(1)
Align the indent with mdp rdma driver.
+#define MIX_INTSTA             0x8
+#define MIX_EN                 0xc
+#define MIX_RST                        0x14
+#define MIX_ROI_SIZE           0x18
+#define MIX_DATAPATH_CON       0x1c
+       #define OUTPUT_NO_RND   BIT(3)
+       #define SOURCE_RGB_SEL  BIT(7)
+       #define BACKGROUND_RELAY        (4 << 9)
+#define MIX_ROI_BGCLR          0x20
+       #define BGCLR_BLACK     0xff000000
+#define MIX_SRC_CON            0x24
+       #define MIX_SRC_L0_EN   BIT(0)
+#define MIX_L_SRC_CON(n)       (0x28 + 0x18 * (n))
+       #define NON_PREMULTI_SOURCE (2 << 12)
+#define MIX_L_SRC_SIZE(n)      (0x30 + 0x18 * (n))
+#define MIX_L_SRC_OFFSET(n)    (0x34 + 0x18 * (n))
+#define MIX_FUNC_DCM0          0x120
+#define MIX_FUNC_DCM1          0x124
+       #define MIX_FUNC_DCM_ENABLE 0xffffffff
+
+#define HDR_VDO_FE_0804_HDR_DM_FE      0x804
+       #define HDR_VDO_FE_0804_BYPASS_ALL      0xfd
+#define HDR_GFX_FE_0204_GFX_HDR_FE     0x204
+       #define HDR_GFX_FE_0204_BYPASS_ALL      0xfd
+#define HDR_VDO_BE_0204_VDO_DM_BE      0x204
+       #define HDR_VDO_BE_0204_BYPASS_ALL      0x7e
+
+#define MIXER_INx_MODE_BYPASS 0
MIXER_INX_MODE_BYPASS
+#define MIXER_INx_MODE_EVEN_EXTEND 1
+#define MIXER_INx_MODE_ODD_EXTEND 2
+#define DEFAULT_9BIT_ALPHA     0x100
+#define        MIXER_ALPHA_AEN         BIT(8)
+#define        MIXER_ALPHA             0xff
+#define ETHDR_CLK_NUM          13
+
+enum mtk_ethdr_comp_id {
+       ETHDR_MIXER,
+       ETHDR_VDO_FE0,
+       ETHDR_VDO_FE1,
+       ETHDR_GFX_FE0,
+       ETHDR_GFX_FE1,
+       ETHDR_VDO_BE,
+       ETHDR_ADL_DS,
+       ETHDR_ID_MAX
+};
+
+struct mtk_ethdr_comp {
+       struct device *dev;
+       void __iomem *regs;
+       struct cmdq_client_reg cmdq_base;
+};
+
+struct mtk_ethdr {
+       struct mtk_ethdr_comp ethdr_comp[ETHDR_ID_MAX];
+       struct clk_bulk_data ethdr_clk[ETHDR_CLK_NUM];
+       struct device *mmsys_dev;
+       spinlock_t lock; /* protects vblank_cb and vblank_cb_data */
+       void (*vblank_cb)(void *data);
+       void *vblank_cb_data;
+       int irq;
+};
+
+static const char * const ethdr_comp_str[] = {
+       "ETHDR_MIXER",
+       "ETHDR_VDO_FE0",
+       "ETHDR_VDO_FE1",
+       "ETHDR_GFX_FE0",
+       "ETHDR_GFX_FE1",
+       "ETHDR_VDO_BE",
+       "ETHDR_ADL_DS",
+       "ETHDR_ID_MAX"
+};
+
+static const char * const ethdr_clk_str[] = {
+       "ethdr_top",
+       "mixer",
+       "vdo_fe0",
+       "vdo_fe1",
+       "gfx_fe0",
+       "gfx_fe1",
+       "vdo_be",
+       "adl_ds",
+       "vdo_fe0_async",
+       "vdo_fe1_async",
+       "gfx_fe0_async",
+       "gfx_fe1_async",
+       "vdo_be_async",
+};
+
+void mtk_ethdr_enable_vblank(struct device *dev,
+                            void (*vblank_cb)(void *),
+                            void *vblank_cb_data)
+{
+       struct mtk_ethdr *priv = dev_get_drvdata(dev);
+       unsigned long flags;
+
+       spin_lock_irqsave(&priv->lock, flags);
+       priv->vblank_cb = vblank_cb;
+       priv->vblank_cb_data = vblank_cb_data;
+       spin_unlock_irqrestore(&priv->lock, flags);
+
+       writel(MIX_FME_CPL_INTEN, priv->ethdr_comp[ETHDR_MIXER].regs + MIX_INTEN);
+}
+
+void mtk_ethdr_disable_vblank(struct device *dev)
+{
+       struct mtk_ethdr *priv = dev_get_drvdata(dev);
+       unsigned long flags;
+
+       spin_lock_irqsave(&priv->lock, flags);
+       priv->vblank_cb = NULL;
+       priv->vblank_cb_data = NULL;
+       spin_unlock_irqrestore(&priv->lock, flags);
+
+       writel(0x0, priv->ethdr_comp[ETHDR_MIXER].regs + MIX_INTEN);
+}
+
+static irqreturn_t mtk_ethdr_irq_handler(int irq, void *dev_id)
+{
+       struct mtk_ethdr *priv = dev_id;
+       unsigned long flags;
+
+       writel(0x0, priv->ethdr_comp[ETHDR_MIXER].regs + MIX_INTSTA);
+
+       spin_lock_irqsave(&priv->lock, flags);
+       if (!priv->vblank_cb) {
+               spin_unlock_irqrestore(&priv->lock, flags);
+               return IRQ_NONE;
+       }
+
+       priv->vblank_cb(priv->vblank_cb_data);
+       spin_unlock_irqrestore(&priv->lock, flags);
+
+       return IRQ_HANDLED;
+}
+
+void mtk_ethdr_layer_config(struct device *dev, unsigned int idx,
+                           struct mtk_plane_state *state,
+                           struct cmdq_pkt *cmdq_pkt)
+{
+       struct mtk_ethdr *priv = dev_get_drvdata(dev);
+       struct mtk_ethdr_comp *mixer = &priv->ethdr_comp[ETHDR_MIXER];
+       struct mtk_plane_pending_state *pending = &state->pending;
+       unsigned int offset = (pending->x & 1) << 31 | pending->y << 16 | pending->x;
+       unsigned int mixer_pad_mode = MIXER_INx_MODE_BYPASS;
+       unsigned int alpha_con = 0;
+       unsigned int fmt = 0;
fmt is useless, so remove.
+
+       dev_dbg(dev, "%s+ idx:%d", __func__, idx);
+
+       if (idx >= 4)
+               return;
+
+       if (!pending->enable) {
+               mtk_ddp_write(cmdq_pkt, 0, &mixer->cmdq_base, mixer->regs, MIX_L_SRC_SIZE(idx));
+               mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_MODE,
+                                    idx + 1, MIXER_INx_MODE_BYPASS, cmdq_pkt);
+               mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_BIWIDTH,
+                                    idx + 1, 0, cmdq_pkt);
+               return;
+       }
+
+       if (pending->x % 2)
+               mixer_pad_mode = MIXER_INx_MODE_EVEN_EXTEND;
+
+       mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_MODE,
+                            idx + 1, mixer_pad_mode, cmdq_pkt);
Drop mixer_pad_mode, and

mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_MODE, idx + 1,
               pending->x & 1 ? MIXER_INx_MODE_EVEN_EXTEND :
MIXER_INx_MODE_BYPASS,
                cmdq_pkt);

Regards,
Chun-Kuang.
+       mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_BIWIDTH,
+                            idx + 1, pending->width / 2 - 1, cmdq_pkt);
+
+       if (state->base.fb && state->base.fb->format->has_alpha) {
+               alpha_con = MIXER_ALPHA_AEN | MIXER_ALPHA;
+               mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_HDR_ALPHA_SEL,
+                                    idx + 1, 0, cmdq_pkt);
+       } else {
+               mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_HDR_ALPHA_SEL,
+                                    idx + 1, 1, cmdq_pkt);
+       }
+       mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_ALPHA_ODD, idx + 1,
+                            DEFAULT_9BIT_ALPHA, cmdq_pkt);
+       mtk_mmsys_ddp_config(priv->mmsys_dev, MMSYS_CONFIG_MIXER_IN_ALPHA_EVEN, idx + 1,
+                            DEFAULT_9BIT_ALPHA, cmdq_pkt);
+
+       mtk_ddp_write(cmdq_pkt, pending->height << 16 | pending->width, &mixer->cmdq_base,
+                     mixer->regs, MIX_L_SRC_SIZE(idx));
+       mtk_ddp_write(cmdq_pkt, offset, &mixer->cmdq_base, mixer->regs, MIX_L_SRC_OFFSET(idx));
+       mtk_ddp_write_mask(cmdq_pkt, alpha_con, &mixer->cmdq_base, mixer->regs, MIX_L_SRC_CON(idx),
+                          0x1ff);
+       mtk_ddp_write_mask(cmdq_pkt, BIT(idx), &mixer->cmdq_base, mixer->regs, MIX_SRC_CON,
+                          BIT(idx));
+}
+
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help