Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop.
From: Sean Paul <sean@poorly.run>
Date: 2021-10-26 01:13:24
Also in:
dri-devel, linux-arm-kernel, lkml
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
From: Mark Yacoub <redacted> [Why] Creating the prop uses UNKNOWN as the initial value, which is not a supported value if the props is to be supported. [How] Set the panel orientation default value to NORMAL right after creating the prop.
Reviewed-by: Sean Paul <redacted>
quoted hunk ↗ jump to hunk
Tested on Jacuzzi(MTK) Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} Signed-off-by: Mark Yacoub <redacted> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 0ad7157660afa..b7c2528a8f41c 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c@@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) DRM_ERROR("Unable to init panel orientation\n"); goto err_cleanup_encoder; } + drm_connector_set_panel_orientation(dsi->connector, + DRM_MODE_PANEL_ORIENTATION_NORMAL); drm_connector_attach_encoder(dsi->connector, &dsi->encoder);-- 2.33.0.1079.g6e70778dc9-goog
-- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek