Re: [PATCH] mailbox: remove the error message when gce clk is defer
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-10-24 20:26:30
Also in:
dri-devel, linux-arm-kernel, lkml
On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
quoted hunk ↗ jump to hunk
Remove the error message when gce clk is defer. Signed-off-by: jason-jh.lin <redacted> --- drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index fd5576a9f8b4..684b8aa1e445 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c@@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev) snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id); cmdq->clocks[alias_id].id = clk_id; cmdq->clocks[alias_id].clk = of_clk_get(node, 0); - if (IS_ERR(cmdq->clocks[alias_id].clk)) { + if (IS_ERR(cmdq->clocks[alias_id].clk) && + PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) { dev_err(dev, "failed to get gce clk: %d\n", alias_id); return PTR_ERR(cmdq->clocks[alias_id].clk); }
So when you get -EPROBE_DEFER, you omit the error message _and_ ignore the -EPROBE_DEFER. Is that really what you want to do? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek