Re: [PATCH -next] ASoC: mediatek: mt8195: Add missing of_node_put()
From: Trevor Wu <hidden>
Date: 2021-09-15 03:07:12
Also in:
alsa-devel, linux-arm-kernel, lkml
Hi Bixuan, Thanks for catching that. I found there are other usages of of_parse_phandle() in the file. Will you handle them together? If not, I will prepare a patch to fix them after this patch is merged. Thanks, Trevor On Sat, 2021-09-11 at 16:12 +0800, Bixuan Cui wrote:
quoted hunk ↗ jump to hunk
The platform_node is returned by of_parse_phandle() should have of_node_put() before return. Reported-by: Hulk Robot <redacted> Signed-off-by: Bixuan Cui <redacted> --- sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.cb/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c index c97ace7387b4..8cd8450409e8 100644--- a/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c +++ b/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c@@ -1041,8 +1041,10 @@ static intmt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev) } priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); - if (!priv) + if (!priv) { + of_node_put(platform_node); return -ENOMEM; + } snd_soc_card_set_drvdata(card, priv);@@ -1050,6 +1052,8 @@ static intmt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev) if (ret) dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n", __func__, ret); + + of_node_put(platform_node); return ret; }
_______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek