Re: [PATCH] mt76: fix determining multicast frame in sta mode

From: Sean Wang <sean.wang@mediatek.com>

quoted

On 2021-08-09 23:13, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>

We should use hdr->addr3 as the destination address to determine the
frame is multicast frame or not when the device is running in sta mode.

We can simply use ieee80211_get_DA for ap mode and sta mode both cases.

That does not make any sense to me. When a sta sends a packet with DA set to a multicast address, it will be sent as unicast to the AP. Why should it be treated as multicast by the driver?

You're right. I should drop the patch earlier. Sorry for the noise.

Eventually, I have found the cause, it is possible to some unicast frame picking up a wrong legacy rate
to send out because the current driver doesn't program the legacy rate information well.
The fix have been provided with ("mt76: mt7921: fix firmware usage of RA info using legacy rates") in [1].

	Sean

[1]
https://patchwork.kernel.org/project/linux-wireless/patch/4be4378630c93ae32a4db8bc3e0871c7b15150a6.1628661185.git.objelf@gmail.com/

- Felix

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek