Re: [PATCH v4 4/4] remoteproc: mediatek: Support mt8195 scp
From: Bjorn Andersson <hidden>
Date: 2021-07-30 15:58:15
Also in:
linux-arm-kernel, linux-devicetree, linux-remoteproc, lkml
On Tue 27 Jul 22:58 CDT 2021, Tinghan Shen wrote:
quoted hunk ↗ jump to hunk
The SCP clock design is changed on mt8195 that doesn't need to control SCP clock on kernel side. Signed-off-by: Tinghan Shen <redacted> --- drivers/remoteproc/mtk_scp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 9679cc26895e..250cb946ea37 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c@@ -785,7 +785,7 @@ static int scp_probe(struct platform_device *pdev) if (ret) goto destroy_mutex; - scp->clk = devm_clk_get(dev, "main"); + scp->clk = devm_clk_get_optional(dev, "main");
This makes the clock optional for mt8183 and mt8192 as well. How about using mtk_scp_of_data to denote if the clock should be acquired? Regards, Bjorn
quoted hunk ↗ jump to hunk
if (IS_ERR(scp->clk)) { dev_err(dev, "Failed to get clock\n"); ret = PTR_ERR(scp->clk);@@ -877,6 +877,7 @@ static const struct mtk_scp_of_data mt8192_of_data = { static const struct of_device_id mtk_scp_of_match[] = { { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data }, { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data }, + { .compatible = "mediatek,mt8195-scp", .data = &mt8192_of_data }, {}, }; MODULE_DEVICE_TABLE(of, mtk_scp_of_match);-- 2.18.0
_______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek