[PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe
From: Yong Wu <yong.wu@mediatek.com>
Date: 2021-07-15 12:13:25
Also in:
linux-arm-kernel, linux-devicetree, linux-iommu, lkml
Subsystem:
mediatek smi driver, memory controller drivers, the rest · Maintainers:
Yong Wu, Krzysztof Kozlowski, Linus Torvalds
Add error handle while component_add fail. Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- It don't have the error handle when v1. it is not a fatal error. thus don't add fix tags. --- drivers/memory/mtk-smi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 6f8e582bace5..e68cbb51dd12 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c@@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) pm_runtime_enable(dev); platform_set_drvdata(pdev, larb); - return component_add(dev, &mtk_smi_larb_component_ops); + ret = component_add(dev, &mtk_smi_larb_component_ops); + if (ret) + goto err_pm_disable; + return 0; + +err_pm_disable: + pm_runtime_disable(dev); + device_link_remove(dev, larb->smi_common_dev); + return ret; } static int mtk_smi_larb_remove(struct platform_device *pdev)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek